Skip to content

feat(address-review-pr): add --ci flag for non-interactive CI mode - #608

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
enxebre:fix/address-review-ci-flag
Jul 7, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
enxebre:fix/address-review-ci-flag

Conversation

@enxebre

@enxebre enxebre commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Add --ci flag to the address-review-pr skill that makes it fully non-interactive.

When --ci is passed: NEVER ask interactive questions or wait for user input. Make autonomous decisions. When in doubt, proceed with the safest action.

Why

The review-agent runs this skill in CI with no human on the other end. When the skill encounters ambiguity or pre-push hook failures, it asks for confirmation and the session ends without completing.

Example: build 2074442484376670208 — the agent wrote correct ratcheting tests for PR #8937, committed locally, but asked "Should I push with --no-verify?" and the session ended with no push. 64 turns, $3.81 spent, work lost.

Ref: CNTRLPLANE-3788

Test plan

  • Run review-agent with --ci flag and verify it pushes without asking
  • Verify interactive mode (no --ci) still prompts as before

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added a new --ci option to the review-pr workflow docs for non-interactive automation.
    • Clarified that CI mode will not prompt for input and will choose the safest action when unsure.
  • Chores
    • Bumped the OpenShift Developer plugin version to 1.1.8 in the marketplace and plugin metadata.

When --ci is passed, the skill runs fully non-interactively:
- Dirty working tree: stash/discard instead of asking
- Comment categorization: proceed without user confirmation
- Ambiguous comments: make autonomous decisions instead of asking
- Pre-push hook failures on pre-existing issues: push with --no-verify

This prevents the agent from blocking on unanswered interactive
prompts when running in CI pipelines.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from bryan-cox and dgoodwin July 7, 2026 15:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cd87e73f-6576-4223-b6d0-e956893a98cb

📥 Commits

Reviewing files that changed from the base of the PR and between fb6434a and 90d7c72.

📒 Files selected for processing (3)
  • docs/index.html
  • plugins/openshift-developer/.claude-plugin/plugin.json
  • plugins/openshift-developer/skills/address-review-pr/SKILL.md

Walkthrough

This PR documents a new --ci non-interactive flag for the openshift-developer skill's address-review-pr command, specifying no interactive prompts and safest-action defaults, and bumps the plugin version from 1.1.7 to 1.1.8 in the manifest and marketplace data.

Changes

Skill Documentation and Version Bump

Layer / File(s) Summary
Document --ci non-interactive mode
plugins/openshift-developer/skills/address-review-pr/SKILL.md
Adds --ci flag to command synopsis, description (no interactive questions, safest-action default), and Arguments list.
Version bump to 1.1.8
plugins/openshift-developer/.claude-plugin/plugin.json, docs/index.html
Updates plugin manifest version and embedded marketplace data version from 1.1.7 to 1.1.8.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: lgtm

Suggested reviewers: bryan-cox, haircommander


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Git Push Safety Rules ❌ Error --ci makes the skill non-interactive, yet Step 4 still runs git push, so it can push autonomously without explicit user permission. Gate every push behind explicit user approval; in --ci, skip push or require a separate, non-interactive approval mechanism before pushing.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a non-interactive --ci flag to address-review-pr.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed The diff only adds --ci text and version bumps; no real-person name is used as a style reference or example in the changed docs or skill text.
No Assumed Git Remote Names ✅ Passed PASS: The PR only adds --ci docs and version bumps; no new remote-name assumptions were introduced, and the existing remote-selection logic is unchanged.
No Untrusted Mcp Servers ✅ Passed Diff only bumps version and adds --ci docs; no new MCP server installs, dependencies, or npx mcp-server commands were introduced.
Ai-Helpers Overlap Detection ✅ Passed PASS: The diff only adds --ci docs to address-review-pr, and the only open PR on that path is #608 itself; README treats it as a distinct post-PR workflow.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 5354659 into openshift-eng:main Jul 7, 2026
6 checks passed
openshift-merge-bot Bot pushed a commit to openshift/release that referenced this pull request Jul 10, 2026
…agent (#81721)

The address-review-pr skill asks interactive questions (e.g., "Should
I push with --no-verify?") that block the session in CI where there
is no human to answer. The --ci flag makes the skill fully
non-interactive.

Depends on: openshift-eng/ai-helpers#608

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
…agent (openshift#81721)

The address-review-pr skill asks interactive questions (e.g., "Should
I push with --no-verify?") that block the session in CI where there
is no human to answer. The --ci flag makes the skill fully
non-interactive.

Depends on: openshift-eng/ai-helpers#608

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
…agent (openshift#81721)

The address-review-pr skill asks interactive questions (e.g., "Should
I push with --no-verify?") that block the session in CI where there
is no human to answer. The --ci flag makes the skill fully
non-interactive.

Depends on: openshift-eng/ai-helpers#608

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
…agent (openshift#81721)

The address-review-pr skill asks interactive questions (e.g., "Should
I push with --no-verify?") that block the session in CI where there
is no human to answer. The --ci flag makes the skill fully
non-interactive.

Depends on: openshift-eng/ai-helpers#608

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants